You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
crypto: requesting patch release with secp256k1 0.33.1, downstream use complicated by yanked status #7106
We've been adopting more of rust-bitcoin in our fork (see dashpay/rust-dashcore#1108) and currently we've had to work around bitcoin-crypto 0.30's dependency (source) on the yanked secp256k1 0.32.0-beta.2 (source) by pulling in the crate by Git commit revision (source).
Even if we opted to disregard the yanked status, it would conflict with our SDK, which uses secp256k1 0.33.1 (source) and the SDK's crates undergoes periodic publication on crates.io (source), we are blocked from using the yanked dependency version.
Though it appears that sticking with the Git revision of bitcoin-crypto has had some odd side effects in how the dependency graph is computed preventing vendoring, requiring a workaround (base-sdk#72) that blocks us from publishing crates.
Suggested Resolution
Publish a patch version of bitcoin-crypto that bumps to secp256k1 0.33.1 or a general estimation on when a release of bitcoin-crypto is on the cards.
Hello, I looked into this and I think it's entirely down to the timing of the release and not a code problem.
On the master branch, crypto, bitcoin and taproot_primitives already depend on secp256k1 = "0.33.0". Cargo already resolves to 0.33.1. I also ran the bitcoin-crypto and bitcoin tests with --all-features on 0.33.1 and everything passes. So the yanked 0.33.0-beta.2 dependency only exists in the bitcoin-crypto 0.30 that's already published, and a fresh release from master should fix it for you.
I would recommend a normal release from master rather than a separate patch branch. I would not mind to help with the release prep, like the changelog and version bumps, or to test a release candidate against your setup. Is there a rough idea of when the next release is pinned?
@kwvg in the meantime, pinning the git rev is probably the only workaround. i know that's awkward with vendoring, sorry.
@apoelstra not to rush you but is there an expected ETA? it appears that the whole crate graph is getting refreshed so an estimate will let us upgrade to the refreshed graph and adapt to changes
Activity
soma-enyi commentedon Oct 27, 2026
Hello, I looked into this and I think it's entirely down to the timing of the release and not a code problem.
On the master branch,
crypto,bitcoinandtaproot_primitivesalready depend onsecp256k1 = "0.33.0". Cargo already resolves to 0.33.1. I also ran thebitcoin-cryptoandbitcointests with--all-featureson 0.33.1 and everything passes. So the yanked0.33.0-beta.2dependency only exists in the bitcoin-crypto 0.30 that's already published, and a fresh release from master should fix it for you.I would recommend a normal release from master rather than a separate patch branch. I would not mind to help with the release prep, like the changelog and version bumps, or to test a release candidate against your setup. Is there a rough idea of when the next release is pinned?
@kwvg in the meantime, pinning the git rev is probably the only workaround. i know that's awkward with vendoring, sorry.
apoelstra commentedon Oct 27, 2026
Neat! Yeah we can do a new
cryptorelease.cryptois a very young WIP crate. I'm surprised to hear that anybody was using it.apoelstra commentedon Oct 27, 2026
Release tracking PR #7103
tcharding commentedon Oct 28, 2026
One more reason to release
primitivesalready.kwvg commentedon Nov 2, 2026
@apoelstra not to rush you but is there an expected ETA? it appears that the whole crate graph is getting refreshed so an estimate will let us upgrade to the refreshed graph and adapt to changes
apoelstra commentedon Nov 2, 2026
primitivesshould be today. Socryptoshould be this week.mpbagot commentedon Nov 6, 2026
@kwvg #7103 has merged and
crypto 0.4.0has been released.apoelstra commentedon Nov 6, 2026
Yep, I'm gonna close this as complete.