Skip to content

crypto: requesting patch release with secp256k1 0.33.1, downstream use complicated by yanked status #7106

Closed
dashpay/rust-dashcore
#1360

Description

@kwvg

Description

We've been adopting more of rust-bitcoin in our fork (see dashpay/rust-dashcore#1108) and currently we've had to work around bitcoin-crypto 0.30's dependency (source) on the yanked secp256k1 0.32.0-beta.2 (source) by pulling in the crate by Git commit revision (source).

Even if we opted to disregard the yanked status, it would conflict with our SDK, which uses secp256k1 0.33.1 (source) and the SDK's crates undergoes periodic publication on crates.io (source), we are blocked from using the yanked dependency version.

Though it appears that sticking with the Git revision of bitcoin-crypto has had some odd side effects in how the dependency graph is computed preventing vendoring, requiring a workaround (base-sdk#72) that blocks us from publishing crates.

Suggested Resolution

  • Publish a patch version of bitcoin-crypto that bumps to secp256k1 0.33.1 or a general estimation on when a release of bitcoin-crypto is on the cards.

Activity

  1. soma-enyi commented on Oct 27, 2026

    @soma-enyi

    Hello, I looked into this and I think it's entirely down to the timing of the release and not a code problem.

    On the master branch, crypto, bitcoin and taproot_primitives already depend on secp256k1 = "0.33.0". Cargo already resolves to 0.33.1. I also ran the bitcoin-crypto and bitcoin tests with --all-features on 0.33.1 and everything passes. So the yanked 0.33.0-beta.2 dependency only exists in the bitcoin-crypto 0.30 that's already published, and a fresh release from master should fix it for you.

    I would recommend a normal release from master rather than a separate patch branch. I would not mind to help with the release prep, like the changelog and version bumps, or to test a release candidate against your setup. Is there a rough idea of when the next release is pinned?

    @kwvg in the meantime, pinning the git rev is probably the only workaround. i know that's awkward with vendoring, sorry.

  2. apoelstra commented on Oct 27, 2026

    @apoelstra
    Member

    Neat! Yeah we can do a new crypto release. crypto is a very young WIP crate. I'm surprised to hear that anybody was using it.

  3. apoelstra commented on Oct 27, 2026

    @apoelstra
    Member

    Release tracking PR #7103

  4. tcharding commented on Oct 28, 2026

    @tcharding
    Member

    One more reason to release primitives already.

  5. kwvg commented on Nov 2, 2026

    @kwvg
    Author

    @apoelstra not to rush you but is there an expected ETA? it appears that the whole crate graph is getting refreshed so an estimate will let us upgrade to the refreshed graph and adapt to changes

  6. apoelstra commented on Nov 2, 2026

    @apoelstra
    Member

    primitives should be today. So crypto should be this week.

  7. mpbagot commented on Nov 6, 2026

    @mpbagot
    Contributor

    @kwvg #7103 has merged and crypto 0.4.0 has been released.

  8. apoelstra commented on Nov 6, 2026

    @apoelstra
    Member

    Yep, I'm gonna close this as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions