Repository navigation
Add Helm chart and GH Action to publish it as an OCI artifact to GHCR - #4
Conversation
Signed-off-by: itvi-1234 <rjsumit71@gmail.com>
ae6ee09 to
454331a
Compare
colinjlacy
left a comment
There was a problem hiding this comment.
Really awesome! I've never done this, so it's cool to see it come together! Just a minor change to help us maintain this going forward, and then we can merge.
| metadata: | ||
| annotations: | ||
| controller-gen.kubebuilder.io/version: v0.21.0 | ||
| controller-gen.kubebuilder.io/version: v0.20.1 |
There was a problem hiding this comment.
Curious why these went down in version number. Not a problem if it's necessary, just not something you usually see.
There was a problem hiding this comment.
It looks like we're duplicating this file, which is likely to introduce drift. Could we instead copy the original as part of the CI pipeline? The Chart.yaml can stay, an we can have a CI job that copies the raw Kubernetes file into the the right folder before the build. That way we only have one version of this file to maintain.
There was a problem hiding this comment.
Same with this file, see above comment.
…pies Signed-off-by: itvi-1234 <rjsumit71@gmail.com>
colinjlacy
left a comment
There was a problem hiding this comment.
I'm still unclear as to why the dependencies went down a minor version, but that's not really a big deal. Worst that happens is we bump it back up later.
Nicely done!!!
| manifests: controller-gen ## Generate the CustomResourceDefinition. | ||
| "$(CONTROLLER_GEN)" crd paths="./..." output:crd:artifacts:config=config/crd/bases | ||
|
|
||
| .PHONY: helm-chart |
Minimal chart wrapping the CRD.
Verified with helm lint, helm template --include-crds, and helm package locally.