Repository navigation
Ts profiler plugin - #7
Merged
Merged
Conversation
internal/process runs a child without a shell. It passes the caller's streams, working directory, and environment through, returns the child's exit status (128 plus the signal for a killed child), and on cancellation sends SIGTERM to the child's process group and kills the group after a grace period. internal/plugins names the executables each optional language looks for on PATH, lets an absolute path in an environment variable override them, checks that the runtime is installed, and reads '<add-on> --version --json' with a time and size limit to learn the add-on's version and core profile schemas.
rc profile typescript <args> runs the installed TypeScript profiler with the arguments unchanged, after checking that it reports the core profile schema rc targets. The add-on's output and exit status pass through, and rc prints nothing when the add-on fails. A missing add-on, a missing runtime, and an incompatible version are each reported once with what to install. rc plugins list shows the built-in Go profiler and each add-on's status, version, and path as text or YAML. Process-level services are injectable through Dependencies, so the commands are tested without real executables, and a test keeps the targeted core schema equal to the one in the component lock.
itvi-1234
force-pushed
the
ts-profiler-plugin
branch
from
November 13, 2026 11:14
d30fa8f to
9695cab
Compare
rc finds an add-on by its executable name on PATH, so it works the same whether the add-on came from the language's own tooling or from a system package. The TypeScript profiler is distributed through npm for developers who want it in their npm scripts. System packages for Homebrew, apt, and yum are planned so that rc and its add-ons install the same way on a build server. The command help and the not-installed message name the npm command, which is what works today. The README keeps one short section on the new commands, and the plan keeps only the status line and the command list.
itvi-1234
force-pushed
the
ts-profiler-plugin
branch
from
November 13, 2026 11:30
9695cab to
81b72a4
Compare
colinjlacy
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.