Skip to content

Remove the legacy paths and the validator that rc replaces - #4

Merged
colinjlacy merged 1 commit into
runtimeconditions:mainfrom
itvi-1234:remove-legacy-paths
Nov 16, 2026
Merged

colinjlacy merged 1 commit into
runtimeconditions:mainfrom
itvi-1234:remove-legacy-paths

Conversation

@itvi-1234

Copy link
Copy Markdown
Member

The profiler makes a profile from installed generated bindings (profile generate), and verifies them (profile verify-bindings). Nothing imports this package: rc does not use the Python profiler, and the only console script is runtimeconditions-python-profiler. The older commands belonged to a separate mapping workflow and carried fixed shapes of particular extensions.

  • Remove the discover, generate, mappings, validate-extension and validate-extensions commands, and everything only they used: the SDK mapping code (sdk/), the handwritten manifest parser and mapping model (manifest/), the source-inspecting profile extractor, the typed profile validator that rc profile validate replaces, project discovery, the extension artifact and manifest validators, and the public API module (main.py) that re-exported them.
  • Remove the helpers of the live code that nothing called: the unused constants, util.py and models.py (ignored_path moves next to workload_source_files), expand_identifier, reference_object and resolve_reference.
  • Remove the tests of the removed code, the authoring fixtures under testdata, the testdata line of MANIFEST.in and the README sentence about the legacy commands.
    .

The profiler makes a profile from installed generated bindings (profile generate), and verifies them
(profile verify-bindings). Nothing imports this package: rc does not use the Python profiler, and the
only console script is runtimeconditions-python-profiler. The older commands belonged to a separate
mapping workflow and carried fixed shapes of particular extensions.

- Remove the discover, generate, mappings, validate-extension and validate-extensions commands, and
  everything only they used: the SDK mapping code (sdk/), the handwritten manifest parser and mapping
  model (manifest/), the source-inspecting profile extractor, the typed profile validator that rc
  profile validate replaces, project discovery, the extension artifact and manifest validators, and the
  public API module (main.py) that re-exported them.
- Remove the helpers of the live code that nothing called: the unused constants, util.py and models.py
  (ignored_path moves next to workload_source_files), expand_identifier, reference_object and
  resolve_reference.
- Remove the tests of the removed code, the authoring fixtures under testdata, the testdata line of
  MANIFEST.in and the README sentence about the legacy commands.

A vulture run on the package reports only the YAML loader's construct_mapping override. The 113
remaining tests pass. Both a wheel and an sdist build, and scripts/check_distributions.py accepts them;
the wheel holds only the modules the two commands use and the two schema files.

Compared with the code before, over 36 cases (a workload with smtp and cache declarations that is valid,
one with an unknown enum value, a value computed at run time, a missing required field, no binding
import, and an empty project, each with profile generate, --out, a missing name and verify-bindings,
with and without --json), the output, error text and exit code of every case are identical, except the
usage text of --help, no arguments and an unknown command, which now lists only profile.
@colinjlacy
colinjlacy merged commit 316ea1c into runtimeconditions:main Nov 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants