Repository navigation
Remove the legacy paths and the validator that rc replaces - #4
Merged
Merged
Conversation
The profiler makes a profile from installed generated bindings (profile generate), and verifies them (profile verify-bindings). Nothing imports this package: rc does not use the Python profiler, and the only console script is runtimeconditions-python-profiler. The older commands belonged to a separate mapping workflow and carried fixed shapes of particular extensions. - Remove the discover, generate, mappings, validate-extension and validate-extensions commands, and everything only they used: the SDK mapping code (sdk/), the handwritten manifest parser and mapping model (manifest/), the source-inspecting profile extractor, the typed profile validator that rc profile validate replaces, project discovery, the extension artifact and manifest validators, and the public API module (main.py) that re-exported them. - Remove the helpers of the live code that nothing called: the unused constants, util.py and models.py (ignored_path moves next to workload_source_files), expand_identifier, reference_object and resolve_reference. - Remove the tests of the removed code, the authoring fixtures under testdata, the testdata line of MANIFEST.in and the README sentence about the legacy commands. A vulture run on the package reports only the YAML loader's construct_mapping override. The 113 remaining tests pass. Both a wheel and an sdist build, and scripts/check_distributions.py accepts them; the wheel holds only the modules the two commands use and the two schema files. Compared with the code before, over 36 cases (a workload with smtp and cache declarations that is valid, one with an unknown enum value, a value computed at run time, a missing required field, no binding import, and an empty project, each with profile generate, --out, a missing name and verify-bindings, with and without --json), the output, error text and exit code of every case are identical, except the usage text of --help, no arguments and an unknown command, which now lists only profile.
colinjlacy
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The profiler makes a profile from installed generated bindings (profile generate), and verifies them (profile verify-bindings). Nothing imports this package: rc does not use the Python profiler, and the only console script is runtimeconditions-python-profiler. The older commands belonged to a separate mapping workflow and carried fixed shapes of particular extensions.
.