Repository navigation
Fix v1alpha2 follow ups - #39
Merged
colinjlacy merged 5 commits intoNov 14, 2026
Merged
Conversation
itvi-1234
commented
Nov 14, 2026
Member
- Add the generated NATS service 0.2.0 extension release that the semantic bridge already describes, and a test that it matches the compiler output.
- Point the nats-service rootExtension at 0.2.0.
- Bump the common-integrations and env-configuration Go and TypeScript bindings to 0.3.0. Their 0.2.0 versions are already published from v1alpha1, and v1alpha2 would otherwise reuse the same version with different content.
- Drop the stale NATS dependency sentence from the env-configuration README; the definition only depends on common-integrations v1alpha2.
- Add the generated NATS service 0.2.0 extension release that the semantic bridge already describes, and a test that it matches the compiler output. - Point the nats-service rootExtension at 0.2.0. - Bump the common-integrations and env-configuration Go and TypeScript bindings to 0.3.0. Their 0.2.0 versions are already published from v1alpha1, and v1alpha2 would otherwise reuse the same version with different content. - Drop the stale NATS dependency sentence from the env-configuration README; the definition only depends on common-integrations v1alpha2.
…o 0.2.0 The generated mapping now matches the 0.2.0 semantic bridge and release. The test that pinned it to the 0.1.0 output now checks the legacy extension release and operations, and a new test checks that the committed mapping equals the compiler output. The nats-service Go, Python and TypeScript bindings follow the extension at 0.2.0.
colinjlacy
reviewed
Nov 14, 2026
Comment on lines
+174
to
+176
| def test_committed_0_2_0_release_matches_the_compiler_output(self): | ||
| self.assertEqual(self.extension, read_document(ROOT / "releases/0.2.0/runtimeconditions.extension.yaml")) | ||
|
|
Contributor
There was a problem hiding this comment.
Do we want to have a test for one sepcific version?
colinjlacy
requested changes
Nov 14, 2026
…model emitter tests The TypeScript and Java real-model tests hard-coded the v1alpha1 common-integrations id as env-configuration's dependency. The committed bindings are now v1alpha2, so the dependency check failed. The tests now take the id from the loaded common-integrations model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.