Repository navigation
feat: run vLLM startup through prestart hooks - #358
Draft
jasonwang-runpod wants to merge 1 commit into
Draft
jasonwang-runpod wants to merge 1 commit into
jasonwang-runpod wants to merge 1 commit into
Conversation
velaraptor-runpod
self-requested a review
October 20, 2026 01:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
vLLM starts before the SDK, so unrecognized startup failures stay in worker logs instead of reaching queued requests.
Solution
Run startup under SDK prestart supervision while keeping jobs queued until startup settles. Preserve existing retries and
startup_errorresponses for known configuration failures. Unrecognized failures now fail one queued job withprestart_failed, include vLLM output, and exit so the platform can restart the worker.Blocked on a stable Runpod SDK 2.0.x release on PyPI.
Testing
4473f30a: queue prompt, chat, streaming, cold starts, and startup failure reporting.