Repository navigation
ci: publish dev runtime images on main #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,8 @@ on: | |
| description: Runpod SDK package spec | ||
| required: true | ||
| default: runpod | ||
| push: | ||
| branches: [main] | ||
|
Comment on lines
+16
to
+17
|
||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
@@ -35,6 +37,10 @@ jobs: | |
| tag="${RELEASE_TAG#v}" | ||
| sdk_spec="runpod" | ||
| release_tags="true" | ||
| elif [ "${{ github.event_name }}" = "push" ]; then | ||
| tag="dev" | ||
| sdk_spec="https://github.com/runpod/runpod-python/archive/refs/heads/main.tar.gz" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because this URL is the same on every run, |
||
| release_tags="false" | ||
| else | ||
| tag="$INPUT_TAG" | ||
| sdk_spec="$INPUT_SDK_SPEC" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no
concurrencygroup, so two merges to main in quick succession run this workflow in parallel, and both push the same-devtags. The 30 runtime jobs and 5 base jobs of the two runs finish in any order, so the result can betask-gpu:py3.12-devfrom the newer run next toqueue-gpu:py3.12-devfrom the older one. A runtime job can also build on top of agpu-base:pyX-devthat the other run has just replaced. Could the workflow get something likeconcurrency: { group: images-${{ github.event_name }}-${{ github.ref }}, cancel-in-progress: true }so only the newest push publishes?