Skip to content

Update 3d weather - #12237

Merged
riktenx merged 17 commits into
runelite:masterfrom
ScreteMonge:3d-weather
May 28, 2026
Merged

riktenx merged 17 commits into
runelite:masterfrom
ScreteMonge:3d-weather

Conversation

@ScreteMonge

Copy link
Copy Markdown
Contributor

Fixes NPE

v1.2.4
- Bugfix: No longer defaults to arctic biome when the season is winter
- Bugfix: WeatherManager arraylist is now handled to avoid ConcurrentModificationExceptions
Update to v1.2.5
- Allow players to use their in-game `Area Sounds` volume setting in place of the plugin's `Ambient Volume` setting

Credits: two-zee
v1.2.6
- Updated BiomeChunkMap to include new areas including Varlamore
v1.2.7
- Config updated to show max weatherObjects in each category
- Bugfix: overlay rendering sometimes causing NPE
- Bugfix: altered threading to reduce burden on clientthread
- Bugfix: rendering weatherObjects on bridge tiles on planes > 0 would cause the overlay/underlay beneath to stop rendering
- ModelOrganizer and ModelImporter can now select multiple files to load
- ModelOrganizer, ModelImporter, and CreatorsPanel now filter out non-json files
- ModelImporter now prioritizes Actor Lighting
- Quick button added for ModelImporter
@runelite-github-app

runelite-github-app Bot commented May 27, 2026

Copy link
Copy Markdown

Added build standard
@ldavid432

Copy link
Copy Markdown
Contributor

Since you have the jaco dependency in your build.gradle you will need to use build=gradle

@ldavid432 ldavid432 added the waiting for author waiting for the pr author to make changes or respond to questions label May 27, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 28, 2026
@runelite-github-app

Copy link
Copy Markdown

Feedback:

  • java.lang.System.err: system i/o, use a logger instead.
  • javax.sound.sampled.SourceDataLine.close: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.FloatControl$Type.MASTER_GAIN: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioSystem.getLine: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.getMicrosecondPosition: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Line: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.DataLine$Info.<init>: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.FloatControl.setValue: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioFormat: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.getControl: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.BooleanControl: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.start: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.open: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.DataLine$Info: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • java.lang.Exception.printStackTrace: system i/o, use a logger instead.
  • javax.sound.sampled.BooleanControl.setValue: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.drain: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioSystem: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Control: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Line$Info: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.stop: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.write: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.FloatControl: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioFormat.<init>: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.flush: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.BooleanControl$Type: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.DataLine: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.BooleanControl$Type.MUTE: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.FloatControl$Type: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Control$Type: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead

A new scan will be automatically performed on the next push to the PR branch.


Internal use only: Reviewer details Maintainer details

@riktenx

riktenx commented May 28, 2026

Copy link
Copy Markdown
Member

please merge ScreteMonge/3D-Weather#39 and include that here, we want to get people off of depending on the "local" jar

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 28, 2026
@riktenx

riktenx commented May 28, 2026

Copy link
Copy Markdown
Member

actually you can just do that later but do please try to follow up on that when you are able

@riktenx
riktenx merged commit 646fa43 into runelite:master May 28, 2026
2 of 3 checks passed
devinlematty pushed a commit to devinlematty/plugin-hub that referenced this pull request May 28, 2026
* Update 3d-weather

* Update 3d-weather

* Update 3d-weather to v1.2.4

v1.2.4
- Bugfix: No longer defaults to arctic biome when the season is winter
- Bugfix: WeatherManager arraylist is now handled to avoid ConcurrentModificationExceptions

* Update 3d-weather

Update to v1.2.5
- Allow players to use their in-game `Area Sounds` volume setting in place of the plugin's `Ambient Volume` setting

Credits: two-zee

* Update 3d-weather

v1.2.6
- Updated BiomeChunkMap to include new areas including Varlamore

* Update 3d-weather to v1.2.7

v1.2.7
- Config updated to show max weatherObjects in each category
- Bugfix: overlay rendering sometimes causing NPE
- Bugfix: altered threading to reduce burden on clientthread
- Bugfix: rendering weatherObjects on bridge tiles on planes > 0 would cause the overlay/underlay beneath to stop rendering

* Update creators-kit to v1.4.3

- ModelOrganizer and ModelImporter can now select multiple files to load
- ModelOrganizer, ModelImporter, and CreatorsPanel now filter out non-json files
- ModelImporter now prioritizes Actor Lighting
- Quick button added for ModelImporter

* Revert creators-kit because wrong branch

* Update 3d-weather

* Update 3d-weather

Added build standard

* Update 3d-weather
Sicryption pushed a commit to Sicryption/valiance-clan-plugin-hub that referenced this pull request Jun 6, 2026
* Update 3d-weather

* Update 3d-weather

* Update 3d-weather to v1.2.4

v1.2.4
- Bugfix: No longer defaults to arctic biome when the season is winter
- Bugfix: WeatherManager arraylist is now handled to avoid ConcurrentModificationExceptions

* Update 3d-weather

Update to v1.2.5
- Allow players to use their in-game `Area Sounds` volume setting in place of the plugin's `Ambient Volume` setting

Credits: two-zee

* Update 3d-weather

v1.2.6
- Updated BiomeChunkMap to include new areas including Varlamore

* Update 3d-weather to v1.2.7

v1.2.7
- Config updated to show max weatherObjects in each category
- Bugfix: overlay rendering sometimes causing NPE
- Bugfix: altered threading to reduce burden on clientthread
- Bugfix: rendering weatherObjects on bridge tiles on planes > 0 would cause the overlay/underlay beneath to stop rendering

* Update creators-kit to v1.4.3

- ModelOrganizer and ModelImporter can now select multiple files to load
- ModelOrganizer, ModelImporter, and CreatorsPanel now filter out non-json files
- ModelImporter now prioritizes Actor Lighting
- Quick button added for ModelImporter

* Revert creators-kit because wrong branch

* Update 3d-weather

* Update 3d-weather

Added build standard

* Update 3d-weather
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin change size-s waiting for author waiting for the pr author to make changes or respond to questions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants