Skip to content

Move Clearance to require signed cookie #6387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colby-swandale wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move Clearance to require signed cookie #6387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/initializers/clearance.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
config.rotate_csrf_on_sign_in = true
config.cookie_expiration = ->(_cookies) { 2.weeks.from_now.utc }
config.routes = false
config.signed_cookie = :migrate
config.signed_cookie = true
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title mentions requiring a "secure cookie", but this change actually enforces a signed remember_token cookie by removing the :migrate shim. Consider updating the title (or adding a clarifying note in the description) so it matches the behavior being changed.

Copilot uses AI. Check for mistakes.
end

class Clearance::Session
Expand Down
Loading