Exclude _xmlschema from RDoc#68
Merged
Merged
Conversation
kanutocd
changed the title
kanutocd
marked this pull request as ready for review
July 20, 2026 04:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exclude the private
_xmlschemaimplementations from RDoc using:nodoc:.After
_xmlschemawas split into version-dependent definitions, Ruby core's RDoc coverage check reports the private helper as undocumented.Since
_xmlschemais an internal implementation detail rather than part of the public API, mark both definitions with:nodoc:so they are excluded from generated documentation.Validation
bundle exec rakepasses inruby/time.ruby/rubycheckout with:which restores 100% documentation coverage.
Originally submitted as ruby/ruby#17977, then moved here because lib/time.rb is maintained in ruby/time.