Repository navigation
Conversation
ksss
reviewed
Oct 11, 2026
Comment on lines
+19
to
+40
| def test_setpgrp | ||
| omit "fork/setpgrp is not available" unless Process.respond_to?(:fork) && Process.respond_to?(:setpgrp) | ||
|
|
||
| # Run in a child process so that the test runner's process group is not changed. | ||
| r, w = IO.pipe | ||
| pid = fork do | ||
| r.close | ||
| assert_send_type "() -> Integer", | ||
| Process, :setpgrp | ||
| exit!(true) | ||
| rescue Exception => e | ||
| w.write(e.full_message(highlight: false)) | ||
| exit!(false) | ||
| end | ||
| w.close | ||
| message = r.read | ||
| _, status = Process.wait2(pid) | ||
| assert_predicate status, :success?, message | ||
| ensure | ||
| r&.close | ||
| end | ||
| end |
Collaborator
There was a problem hiding this comment.
I am not sure if we need to go this far to check the type of Process.setpgrp.
Unstable tests are not welcome.
Add signatures for singleton methods that are defined in Ruby 4.0 but were missing from core/: - Hash.ruby2_keywords_hash, Hash.ruby2_keywords_hash? - Kernel.set_trace_func, Kernel.trap - Process.last_status, Process.setpgrp - Process::Status.wait - Process::Sys.getegid
zonuexe
force-pushed
the
add-missing-singleton-methods
branch
from
October 11, 2026 13:43
3ffddb2 to
e36555b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds signatures for singleton methods that Ruby 4.0 defines and
core/lacks. I left outRubyVMinternals andProcess::Tms.[].rbs annotategenerated the doc comments from the v4.0.7 RDoc.Hash.ruby2_keywords_hashHash(Check_Type, noto_hashconversion) and returns an instance of the argument's class, subclasses includedrb_hash_s_ruby2_keywords_hashHash.ruby2_keywords_hash?Hash(Check_Type, noto_hashconversion)rb_hash_s_ruby2_keywords_hash_pKernel.set_trace_funcset_trace_funcKernel.trapSignal.trap, so it uses the same signaturesig_trapProcess.last_statusniluntil the current thread has a child statusproc_s_last_statusProcess.setpgrpproc_setpgrpProcess::Status.waitnilwhenflagsincludesWNOHANGand no child has exited (source). The call-seq omits this caserb_process_status_waitvProcess::Sys.getegidproc_getegidThe
Process.setpgrptest runs in a forked child, so the test runner keeps its process group.