Skip to content

✅🚧 Mark local stacktrace tests pending for JRuby #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nevans wants to merge 1 commit into
base: master
Choose a base branch
from
Open

✅🚧 Mark local stacktrace tests pending for JRuby #729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/lib/helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,9 @@ def assert_local_raise(expected, message = nil)
assert_raise(expected, &block)
end
stack = caller
assert_equal stack, error.backtrace&.last(stack.size)
pend_if_jruby("JRuby bug: jruby/jruby#9528, fixed by: jruby/jruby#9548") do
assert_equal stack, error.backtrace&.last(stack.size)
end
error
end

Expand All @@ -221,6 +223,7 @@ def assert_local_raise(expected, message = nil)
# it can capture the top of the stacktrace. After that, it'll continue to use
# the same stacktrace.
def assert_reraised(*args, imap: nil, &block)
return assert_local_raise(*args, &block) if RUBY_ENGINE == "jruby"
@rcvr_thread_trace ||= imap.instance_variable_get(:@receiver_thread)
&.backtrace&.last(2)
error = assert_local_raise(*args, &block)
Expand Down
Loading