✅ Move various IMAP client tests to their own files - #728
Merged
Conversation
This is partially deprecated. Most tests should use `FakeServer` instead. But it may continue to be used for tests that intentionally violate normal IMAP protocol behavior, for example when testing SSL error conditions, abrupt network disconnects, etc, where it's simpler to just use a straight TCP server socket.
nevans
force-pushed
the
reorg-imap-client-tests
branch
from
July 31, 2026 22:04
015692c to
04b84ad
Compare
This matches the pattern used by most other current "integration tests".
This matches the pattern used by most other current "integration tests".
This matches the pattern used by most other current "integration tests".
In keeping with the naming convention that `test_imap*.rb` files are for client integration tests, this test file must be renamed because it does not create a client connection. It only tests class methods.
nevans
force-pushed
the
reorg-imap-client-tests
branch
from
August 3, 2026 18:00
04b84ad to
877c739
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests weren't moved back when #515 moved most of the rest. This moves over 1000 lines from
test_imap.rbinto new files for:#idleand#idle_done#id#starttlstest_command_data.rb)Also:
test_data_encoding.rbwas renamed because it did not match the naming convention of usingtest_imap*.rbonly for integration test files.Still in
test_imap.rb:#disconnect- this could be moved to its own file. But it isn't an IMAP command; it directly manages client's connection. So I've left it here for now.