Skip to content

Highlight an expanded folder as one group on hover (build 41) - #47

Merged
ruban-24 merged 2 commits into
mainfrom
feature/v1-folder-group-hover
Oct 23, 2026
Merged

ruban-24 merged 2 commits into
mainfrom
feature/v1-folder-group-hover

Conversation

@ruban-24

Copy link
Copy Markdown
Owner

UAT feedback: hovering a folder should highlight all of its sessions, and you should still be able to hover each session on its own.

  • With the pointer anywhere on an expanded folder, header or sessions, the whole shaded block deepens from 5% to 10% primary.
  • A session under the pointer still adds its own highlight on top.
  • The expanded header no longer draws a separate row highlight. A collapsed folder keeps its row highlight.
  • Hover is tracked per row (hoveredFolderRows), so moving between two rows of one folder can't drop the group highlight when one row's enter fires before the other's exit. The tracking clears when the menu closes.

This stays at build 41. Build 41 was never notarized: the release verifier misread the signatures during my background run, and the same verifier passes when run directly on that export.

Docs: the release notes hover bullet and ATTENDED-UAT "Menu and Settings layout" case 2.

Verification: the Debug build succeeds and the public-source guard passes. This is a view-only change and the Swift tests are unaffected.

🤖 Generated with Claude Code

With the pointer anywhere on an expanded folder, its header or any of its
sessions, the folder's whole shaded block deepens, and a session under the
pointer adds its own highlight on top. The folder header no longer draws a
separate row highlight while expanded. Rows are tracked individually, so
moving between rows of one folder never flickers the group highlight off.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T02:51:48.899477Z cb53bb3 PR opened
🔒 Security Review 🔄 Running since 2026-10-23T02:49:47.558389Z cb53bb3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Oct 23, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb53bb39d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/LetItBrewApp/MenuBarContentView.swift
A hovered row can vanish without a hover exit, for example after Stop
Watching, and collapsing a folder moves its header out of the folder block.
Whenever the board's rows change, keep only hover entries for rows still
shown in the folder they were hovered in, so the folder highlight cannot
stick after the pointer leaves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ruban-24
ruban-24 enabled auto-merge (squash) October 23, 2026 02:54
@claude

claude Bot commented Oct 23, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@ruban-24
ruban-24 disabled auto-merge October 23, 2026 02:57
@ruban-24
ruban-24 merged commit 6f6fce0 into main Oct 23, 2026
5 checks passed
@ruban-24
ruban-24 deleted the feature/v1-folder-group-hover branch October 23, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant