Repository navigation
Fix - Restrict privacy modification on media and album edit - #2378
Merged
Merged
Conversation
…n UI is not exposed
Contributor
|
Unable to PHPCS or SVG scan one or more files due to error running PHPCS/SVG scanner:
The error may be temporary. If the error persists, please contact a human (commit-ID: 9751781). |
Merged
the-hercules
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents updating privacy on single media and album edit requests when the privacy field is not available in the UI.
Changes
Single Media Edit (
RTMediaTemplate::save_single_edit()):$_POST['privacy']if editing group media, moderated media (privacy == 80) and when user privacy override is disabled.privacyin$data_arrayif$_POST['privacy']is present and allowed.privacyunconditionally in POST requests presently.Album Edit (
RTMediaTemplate::save_album_edit()):privacyfrom$data_arrayand unsets$_POST['privacy'].album-single-edit.phpdoes not have a privacy field in the frontend. Submittingprivacyin POST should not modify the album's privacy.