Skip to content

Fix - Restrict file upload sideloading and enforce extension validation #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Intenzi merged 2 commits into from
Oct 1, 2026
Merged

Fix - Restrict file upload sideloading and enforce extension validation #2374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62baca7
fix: strictly validate file extension and remove MIME type regex fall…
Intenzi Sep 30, 2026
90fdb0c
fix: restrict file uploads to standard multipart $_FILES to prevent a…
Intenzi Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions app/main/controllers/upload/processors/RTMediaUploadFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public function process() {
include_once ABSPATH . 'wp-admin/includes/file.php';
include_once ABSPATH . 'wp-admin/includes/image.php';

$upload_type = $this->fake ? 'wp_handle_sideload' : 'wp_handle_upload';
$upload_type = 'wp_handle_upload';

// todo why use $rt_set_filter_uplaod_dir global variable if we can remove filter for upload_dir after upload finish.
global $rt_set_filter_uplaod_dir;
Expand Down Expand Up @@ -173,16 +173,9 @@ public function upload_dir( $upload_dir ) {
*/
public function set_file( $files ) {
/**
* If files parameter is provided then take th file details from that object
* Check for $_FILES global object from the form submitted
*/
if ( $files ) {

$this->fake = true;
$this->populate_file_array( (array) $this->uploaded['files'] );
/**
* Otherwise check for $_FILES global object from the form submitted
*/
} elseif ( isset( $_FILES['rtmedia_file'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing -- We are just checking if the value exists over here.
if ( isset( $_FILES['rtmedia_file'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing -- We are just checking if the value exists over here.
$this->populate_file_array( array_map( 'sanitize_text_field', $_FILES['rtmedia_file'] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing -- We are just checking if the value exists over here.
// The function populate_file_array is sanitizing string and integer values.
} else {
Expand Down Expand Up @@ -249,10 +242,8 @@ public function is_valid_type( $file ) {
);
$allowed_types = explode( ',', $allowed_types[0]['extensions'] );

if ( false === in_array( strtolower( $file_data['ext'] ), $allowed_types, true ) ) {
if ( ! preg_match( '/' . implode( '|', $allowed_types ) . '/i', $file['type'], $result ) || ! isset( $result[0] ) ) {
throw new RTMediaUploadException( UPLOAD_ERR_EXTENSION );
}
if ( empty( $file_data['ext'] ) || false === in_array( strtolower( $file_data['ext'] ), $allowed_types, true ) ) {
throw new RTMediaUploadException( UPLOAD_ERR_EXTENSION );
}
} catch ( RTMediaUploadException $e ) {
echo esc_html( $e->getMessage() );
Expand Down
Loading