Repository navigation
Fix - Enforce Album permissions, allowlist, sanitization on media edit - #2373
Merged
Merged
Conversation
Contributor
|
Unable to PHPCS or SVG scan one or more files due to error running PHPCS/SVG scanner:
The error may be temporary. If the error persists, please contact a human (commit-ID: be9386a). |
NoumaanAhamed
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses authorization and mass database assignment vulnerabilities in media edit requests.
Changes
Album Permission Check: Added
rtmedia_current_user_can_add_to_album()verification inRTMediaTemplate::save_single_edit()before allowing media to be moved to a destination album.Strict Allowlist Sanitization: Updated
rtmedia_sanitize_object()to enforce a strict allowlist using the$exceptionsparameter, preventing arbitrary database columns (e.g.,media_author,views,likes) from being modified.Privacy Level Validation: Validated
privacykey input viartmedia_sanitize_privacy_level()to ensure only allowed privacy integers are stored.