Repository navigation
feat: implement _server.yml standard - #4437
Open
JosiahParry wants to merge 1 commit into
Open
JosiahParry wants to merge 1 commit into
JosiahParry wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an internal
launch_server()function that satisfies the requirements of the _server.yml standard.I went ahead and followed the same argument and configuration precedence in the nanonext pr where HOST & PORT env var are respected over everything, followed by the config in
_server.ymland lastly the defaults.I have an issue on precedence open that may be nice to nail down formally.
I based the
_server.ymlstructure on therunApp()arguments and chose only the ones that I suspect would be relevant for a "production" environment.