Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4026.
serializeReactiveValues()(used bysession$doBookmark()) calledimpl$get(name)for every reactive value, including ones frozen viafreezeReactiveValue(). Reading a frozen value raises a silentshiny.silent.errorviareactiveStop(), which propagated out of the serialization loop and aborted bookmarking with "Error bookmarking state".Since a frozen value is explicitly pending an update (and is expected to be thawed on the next flush), it doesn't have a meaningful value to persist at the moment bookmarking runs. This fix skips frozen keys before they're read, so they're omitted from the bookmarked state rather than causing an error.
Added tests in
tests/testthat/test-serializers.Rcovering that a frozen input is excluded without erroring, and that non-frozen inputs still serialize as before.