Wrap up bslib integration - #308
Merged
Merged
Conversation
cpsievert
force-pushed
the
carson/feature/bslib
branch
from
February 12, 2021 22:59
56f566d to
90deed4
Compare
…for bslib's new navbar-bg based on primary Also, make sure the modified theme passes through shiny::bootstrapLib
cpsievert
added a commit
to rstudio/shiny
that referenced
this pull request
Feb 18, 2021
…dates stylesheet(s). Will be useful for real-time theming integration in flexdashboard rstudio/flexdashboard#308
cpsievert
commented
Feb 18, 2021
cpsievert
marked this pull request as ready for review
February 18, 2021 23:03
This was referenced Feb 19, 2021
cpsievert
commented
Feb 19, 2021
cpsievert
added a commit
that referenced
this pull request
Feb 22, 2021
cpsievert
added a commit
that referenced
this pull request
Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes integration with
{bslib}, to be merged after rstudio/rmarkdown#2049See here for a basic explanation/announcement.
See here for a full-blown example