fix: scope element expression walk to dotted property containers only (OOM) - #5
Merged
Merged
Conversation
Fixes OOM crash: element.iter() on container activities (Sequence, If, etc.) walked all descendant activities, causing quadratic expression accumulation. Now only descends into dotted property children (Assign.To, InvokeMethod.Parameters) which is where VisualBasicValue elements legitimately appear. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OOM crash introduced in 0.1.2.
element.iter()on container activities (Sequence, If, etc.) walked ALL descendant activities, causing quadratic expression accumulation — expressions from child activities collected by the parent, then again by each child.Fix: only descend into direct children whose local tag contains a dot (e.g.
Assign.To,InvokeMethod.Parameters). These are property containers, not child activities, and are the only valid nesting locations forVisualBasicValueelements.