fix: extract ExpressionText from VisualBasicValue/VisualBasicReference child elements - #4
Merged
Conversation
…e child elements Closes #2 Previously, expressions encoded as child-element syntax (Syntax B) were silently dropped. Adds descendant walking in _extract_business_logic_expressions and dotted-property container traversal in _extract_activity_arguments so that variable references in VisualBasicValue/VisualBasicReference/CSharpValue/CSharpReference elements are included in call graphs, pseudocode, and variable analysis. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
Summary
_EXPR_ELEMENT_TAGSmodule-levelfrozensetconstant inextractors.py_extract_business_logic_expressions: walk all descendant elements and addExpressionTextdirectly (raw VB.NET/C# expression, no bracket wrapping)_extract_activity_arguments: traverse dotted-property child containers (e.g.InvokeMethod.Parameters) and collectExpressionTextfrom nestedInArgument/OutArgument/InOutArgument→ expression element chainsVisualBasicValue,VisualBasicReference, mixed syntax, and argument extractionTest plan
uv run pytest tests/unit/test_extractors.py -q --no-cov— all passtest_profiler_overhead_disabled,test_view_query_methods) are unrelated and present onmain🤖 Generated with Claude Code