Repository navigation
Ropensci sofware peer review second round of revisions - #7
Merged
Merged
Conversation
Pull changes from v2.1.0
…varroD/RAMEN into ropensci-software-review # Conflicts: # NEWS.md
…y are used in the package tests
…ctions check for matched invdividual IDs across all objects.
…1 SNP and no covariates.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes some minor bugs in RAMEN including:
check for matched IDs across all objects.
nullDistGE()where the seed was fixed to 1 during theselectVariables()step instead of using the seed argument provided.selectVariables()where the function would throw an errorwhen, in the absence of covariates, a VML had only 1 SNP. In that case, the
variable selection for G is now not conducted and the same SNP is returned.
lmGE()where the function would throw an error when nocovariates were fed into the function.
In addition to that, we added a section on the vignette explaining how to set
up a parallel backend, and expanding on the data assumptions/expectations
from RAMEN.
Finally, the Illumina annotation packages are now a dependency, rather than a
suggestion, as they are needed during the package tests.
This patch presents no changes on the user's end.