Repository navigation
Implement Level Move Mode Configuration for Switch Clusters - #553
Open
cmiguelcabral wants to merge 2 commits into
Open
cmiguelcabral wants to merge 2 commits into
cmiguelcabral wants to merge 2 commits into
Conversation
- Added level_move_mode field to zigbee_switch_cluster_config structure - Implemented support for three movement modes: ALTERNATE, ONLY_UP, ONLY_DOWN - Updated config parser to initialize level_move_mode correctly - Modified switch_cluster_level_control function to respect configured movement mode - Enhanced NVM migration logic to handle existing configurations - Added proper validation for level move mode values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for configurable level move modes in switch clusters, enabling users to select between different movement behaviors when using level control functionality.
Changes included:
NVM Structure Enhancement: Added
level_move_modefield tozigbee_switch_cluster_configstructure (9 bytes total)Configuration Support: Implemented three movement modes:
Migration Logic: Enhanced NVM migration to properly handle existing configurations
Control Logic: Updated
switch_cluster_level_controlfunction to respect configured modesInitialization Fix: Corrected field initialization in config parser
Technical Details:
Testing:
Usage: Users can now configure the level move behavior via Zigbee bind, allowing for more flexible control of switch clusters based on their specific requirements.