Skip to content

Update pyproject.toml: constrain numpy<2 - #88

Closed
james-pcdr wants to merge 1 commit into
romanz:masterfrom
james-pcdr:patch-1
Closed

Update pyproject.toml: constrain numpy<2#88
james-pcdr wants to merge 1 commit into
romanz:masterfrom
james-pcdr:patch-1

Conversation

@james-pcdr

Copy link
Copy Markdown
Contributor

Hello,

I got the following error when trying to use send:

  File ".../amodem/amodem/common.py", line 31, in dumps
    return sym.astype('int16').tostring()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'numpy.ndarray' object has no attribute 'tostring'

When I installed numpy 1.x rather than 2.x, it seemed to fix it.

Please let me know if you would like any further information. Thanks!

@romanz

romanz commented Oct 16, 2025

Copy link
Copy Markdown
Owner

Thanks!
Could you please remove the unsupported Python versions (3.7 & 3.8) from:

python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]

@james-pcdr

Copy link
Copy Markdown
Contributor Author

Sure. I figured you wanted it all in one commit, so I started a new PR, #89.
Let me know if you have any other requests. 👍

@romanz

romanz commented Nov 12, 2025

Copy link
Copy Markdown
Owner

Thanks!

@romanz romanz closed this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants