[FIX][ISSUE-370] update consumer rules#372
Conversation
|
@claude review |
There was a problem hiding this comment.
LGTM — straightforward ProGuard consumer rules cleanup.
Extended reasoning...
Overview
This PR modifies two ProGuard rules files:
rollbar-android/proguard-rules.pro: removes the-renamesourcefileattribute SourceFiledirective (which is a global ProGuard/R8 option not appropriate for library consumer rules), uncomments-keepattributes SourceFile,LineNumberTable, and adds an explanatory comment directing app developers to add the rename rule to their own app's proguard-rules.pro if desired.examples/rollbar-android/proguard-rules.pro: removes commented-out template lines for the same options.
Security risks
None. ProGuard rules govern build-time obfuscation/shrinking and don't affect runtime authentication, data handling, or any security-sensitive logic.
Level of scrutiny
Low scrutiny is appropriate. This is a build-configuration fix addressing a known ProGuard/R8 best practice — global options like -renamesourcefileattribute should not be embedded in library consumer rules because they would silently impact every app consuming the library. The fix is mechanical, the rationale is clearly documented inline, and the explanatory NOTE for downstream consumers is helpful.
Other factors
Bug hunting found no issues. The change is small (two files), self-contained, and aligns with the linked issue #370. No code logic, no API surface, no tests affected.
|
@codex please review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Description of the change
Remove global ProGuard option from consumer rules
Type of change
Related issues
Checklists
Development
Code review