Repository navigation
Retire orphaned undefined p/f events after cancellation grace - #261
Merged
Merged
Conversation
Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ローカルの p/f を正常に受信しても、following から消えた終了未定番組が永続的に残る問題を修正します。以前の実装は未放送 following の消失時にフラグを解除して保持し、その後は p/f フラグがない番組を再判定の対象から除外していました。
完全な p/f の受信時刻を渡し、現在の p/f に存在せず、開始予定から3時間を超え、保存時刻も未定の番組を、フラグに依存せず削除・remove 通知します。ARIB TR-B14 19.3 / TR-B39 20.3 の休止判定を踏まえた保存方針です。現在放送・中断中の p/f、未来・開始未定の番組、時刻既知の履歴は保持し、終了時刻は推定しません。
修正前に回帰テストが失敗することを確認し、3時間ちょうど/超過、フラグ解除・再起動後の再判定、現在・中断・未来番組と他局の保護、削除失敗時のロールバックと通知を検証しました。
検証: go build ./...、make verify、golangci-lint run ./...(0 issues)。本番の現在の p/f は両サービスとも完全な同一版のペアを受信でき、旧 ID 6473 が含まれていないことを信号で確認済みです。デプロイ後にローカル通常受信で残存2件の削除と通知を確認します。