Repository navigation
Reconcile remote program removals and undefined events - #260
Merged
Merged
Conversation
Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remote が正しく番組を削除しても Mahiron が remove 通知を無視し、定期同期の対象期間より前にある終了未定番組も残っていた問題を修正します。
remote の remove を既知サービスに限定して反映し、直前の保留更新を保存してから削除することで、同一 ID の更新→削除→再作成の順序を保ちます。削除と通知は保存成功後に確定し、重複通知は冪等に扱います。
定期同期では対象期間と重なる番組に加えて終了未定番組も照合し、一覧にない残存番組を削除します。対象期間より前に終了した時刻既知の履歴・他局の番組は保持します。置換前の取得範囲と削除範囲も一致させ、削除通知の欠落を防ぎます。
検証: go build ./...、make verify、関連回帰テスト、golangci-lint run ./...(0 issues)。順序、削除失敗、重複、未知サービス、対象期間より前の終了未定番組と履歴の保持を検証済みです。
デプロイは日時付き nightly タグを使用し、本番で残っている NHK 総合・東京の終了未定2件が通常の remote 同期で整理されるか確認します。