Repository navigation
fix(mcp): address review round 1 on the stateless facade - #2
Merged
octobroker[bot] merged 1 commit intoOct 26, 2026
Merged
Conversation
- F1: gmail adapter doc no longer claims to mirror the facade transport; it states that gmail is still stateful (same idle/restart 404 exposure) and what must be shared before it can go stateless. Also correct "one instance per serve process" for HTTP mode. - F2: scope the 2026-07-28 claim to the removal of protocol-level sessions (the facade still speaks the 2025 initialize handshake), in the build_router doc and docs/oab-mcp-facade.md. - F3: ADR 6.2 gains a "Stateless transport" bullet (gmail remains stateful); the operator guide states that a stale Mcp-Session-Id is ignored rather than rejected, and the Trust model section now says "agent session" for the bearer-backed session so it is not confused with the MCP protocol session; the e2e test doc says "session-token (bearer) mechanism". - F4: the regression test checks the initialize body (result + protocolVersion, no error) and asserts DELETE /mcp -> 405 alongside GET, both with Allow: POST. - From the earlier non-blocking notes: document that future facade tools must not rely on server->client requests or the GET SSE stream, and note why NeverSessionManager is intentionally redundant with stateful_mode = false. Agent-Bot: alpha Co-authored-by: rockexe0000 <rockexe0000@gmail.com>
4 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging PR for the owner's review. Base is
fix/facade-stateless(the head of openabdev#1578); once approved,fix/facade-statelessis fast-forwarded to this commit, which updates openabdev#1578. Do not merge here.Addresses round 1 of the openabdev#1578 review (F1–F4) plus two of the earlier non-blocking notes:
native/gmail.rs: theserve_httpdoc no longer claims to mirror the facade transport; it says gmail is still stateful (same idle/restart 404 exposure) and that thereqwest::Clientand refresh lock must be shared outside the per-session factory before it can go stateless.GmailNativedoc: one instance per stdioserveprocess, or per MCP session over HTTP.initializehandshake), in both thebuild_routerdoc anddocs/oab-mcp-facade.md.Mcp-Session-Idis ignored rather than rejected; the Trust model section now says "agent session" for the bearer-backed session, with a one-line note that it is unrelated to the MCP protocol session; the e2e test doc says "session-token (bearer) mechanism".initializebody (result+protocolVersion, noerror) and assertsDELETE /mcp→405alongsideGET, both withAllow: POST.NeverSessionManageris intentionally redundant withwith_stateful_mode(false).Not in this round (reviewer marked them follow-ups / non-blocking): gmail stateless switch, idempotency keys, cancellation-token propagation,
json_response, bearer-miss debug logging,cargo audit, tense alignment in the two "is being removed" docs.🤖 Generated with Claude Code