Repository navigation
Translate the rest of the web UI into Korean - #93
Merged
Merged
Conversation
All 152 keys in en.ts now have Korean, up from 16. Memory is 메모리 to match how ChatGPT, Claude and Gemini name the feature in Korean, and placeholders sit where no particle depends on the inserted value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks @rxolve! Very careful Korean translation, and the notes on terminology and particle placement were really helpful. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #46. This translates all 152 keys in
en.tson main into Korean, up from 16. When Korean is selected, every string extracted so far now shows in Korean, including those on the Tasks and Memory pages.writeMessagejoins the parts of a save message with " · ", and full sentences read badly between the dots.“{title}” 할 일이 영구적으로 삭제됩니다, the word 할 일 ("task") comes between the title and the particle 이, so the particle never has to change to 가.memory.olderKepthas onlyother, since Korean has a single plural category.The keys that #85 adds are not on main yet. I'll translate them once it lands.
I ran
npm test -w @talorys/web,tsc --noEmit -p apps/webandnpm run lint, and all three pass. I also opened Tasks, the task editor and Memory in Korean on the local stack at desktop and mobile widths, and no label overflowed or was cut off.Prepared with Claude Code and checked by the person posting.