Repository navigation
Keep a checkbox inside a code sample from becoming a task - #90
Merged
Merged
Conversation
A sample that shows another fence, or a shorter fence inside a longer one, was checked off as a real todo, and the task after the sample was left alone.
Typecheck treats each capture as optional, so a real fence line failed the build before the checkbox logic ran.
rudycelekli
force-pushed
the
fix/notes-code-fence-todos
branch
from
October 24, 2026 04:45
326fbe2 to
2368f3f
Compare
Owner
|
Thanks, the fence tracking looks right and the new tests cover both cases. CI failed on an end-to-end test that this PR doesn't touch: Two small nits, not blocking:
|
Owner
|
Thanks @rudycelekli! The fence tracking fix and the new tests look good. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checking off a task in a note treated a checkbox inside a code sample as a real task when the sample showed a
~~~fence, or a shorter fence inside a longer one. The task after that sample could not be toggled from the editor.Test
npx vitest run test/writer-tasks.test.tsinapps/web. The two new cases fail on main and pass here.