Skip to content

handle shell.c on alpine #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tantaman merged 1 commit into from
Aug 13, 2026
Merged

handle shell.c on alpine #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
{
'includes': ['deps/common.gypi'],
'variables': {
'is_alpine%': '<!(test -f /etc/alpine-release && echo 1 || echo 0)',
# Emit "true"/"false" rather than 1/0: gyp converts command output that
# looks like an integer into a real int, so a later `is_alpine == "1"`
# string comparison would silently never match.
'is_alpine%': '<!(test -f /etc/alpine-release && echo true || echo false)',
},
'targets': [
{
Expand Down Expand Up @@ -35,7 +38,7 @@
{
'target_name': 'zero_sqlite3',
'conditions': [
['is_alpine == "1"', {
['is_alpine == "true"', {
'type': 'none',
'dependencies': [],
'sources': [],
Expand All @@ -47,7 +50,14 @@
'direct_dependent_settings': {
'include_dirs': ['<(SHARED_INTERMEDIATE_DIR)/sqlite3/'],
},
'cflags': ['-std=c99', '-w', '-D_POSIX_SOURCE'],
# gnu99, not "c99 + _POSIX_SOURCE": shell.c needs PATH_MAX and
# realpath(), which neither glibc nor musl declares under that pair
# (musl also stops defaulting to _XOPEN_SOURCE 700 once __STRICT_ANSI__
# or _POSIX_SOURCE is set). gcc <= 13 only warns about the resulting
# implicit realpath() declaration -- and -w hides that -- so the shell
# links with a truncated 32-bit return value; gcc >= 14 makes it a hard
# error that -w does not suppress.
'cflags': ['-std=gnu99', '-w'],
'xcode_settings': {
'OTHER_CFLAGS': ['-std=c99'],
'WARNING_CFLAGS': ['-w'],
Expand Down
3 changes: 0 additions & 3 deletions deps/sqlite3.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@

{
'includes': ['common.gypi'],
'variables': {
'is_alpine%': '<!(test -f /etc/alpine-release && echo 1 || echo 0)',
},
'targets': [
{
'target_name': 'locate_sqlite3',
Expand Down
Loading