chore: move the tests to the v1 apis - #153
Merged
Merged
Conversation
Bump api-go to the v1-only beta.14 with resetter beta.5, metrics beta.6 and status beta.7. The resetter proto is gone in beta.14, so resetAll now uses the plain struct RPC surface: resetter.List and resetter.Reset. The new betas require go 1.27, which bumps the tests module and the workspace.
Deprecation notices printed on stdout before the first frame corrupt the goridge handshake. Route display_errors to stderr before autoload, as the bench worker already does.
The autobuild step runs with GOTOOLCHAIN=local, and go.work requires go 1.27 while go.mod resolves to 1.26.x, so extraction fails. Installing the toolchain from go.work satisfies both modules.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 78.41% 84.81% +6.39%
==========================================
Files 10 10
Lines 746 652 -94
==========================================
- Hits 585 553 -32
+ Misses 117 99 -18
+ Partials 44 0 -44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the tests module to the v1-only api-go beta.14 with resetter beta.5, metrics beta.6 and status beta.7. The resetter proto is gone in beta.14, so resetAll in tls_test.go now uses the plain struct RPC surface (resetter.List, resetter.Reset). The new betas require go 1.27, which bumps the tests module and the workspace.
Two side fixes in the same area:
The full test suite passes locally against the bumped stack.