Skip to content

chore: move the tests to the v1 apis - #153

Merged
rustatian merged 3 commits into
masterfrom
chore/v1-apis
Aug 21, 2026
Merged

rustatian merged 3 commits into
masterfrom
chore/v1-apis

Conversation

@rustatian

Copy link
Copy Markdown
Member

Moves the tests module to the v1-only api-go beta.14 with resetter beta.5, metrics beta.6 and status beta.7. The resetter proto is gone in beta.14, so resetAll in tls_test.go now uses the plain struct RPC surface (resetter.List, resetter.Reset). The new betas require go 1.27, which bumps the tests module and the workspace.

Two side fixes in the same area:

  • the grpc php workers now route display_errors to stderr before autoload, like the bench worker already did, so deprecation notices cannot corrupt the goridge handshake on stdout
  • the CodeQL workflow installs go from go.work: autobuild runs with GOTOOLCHAIN=local and fails once go.work requires a newer toolchain than go.mod resolves to (this is what broke the CodeQL job on the last centrifuge dependabot PR, and grpc has the same layout)

The full test suite passes locally against the bumped stack.

Bump api-go to the v1-only beta.14 with resetter beta.5, metrics beta.6 and status beta.7. The resetter proto is gone in beta.14, so resetAll now uses the plain struct RPC surface: resetter.List and resetter.Reset. The new betas require go 1.27, which bumps the tests module and the workspace.
Deprecation notices printed on stdout before the first frame corrupt the goridge handshake. Route display_errors to stderr before autoload, as the bench worker already does.
The autobuild step runs with GOTOOLCHAIN=local, and go.work requires go 1.27 while go.mod resolves to 1.26.x, so extraction fails. Installing the toolchain from go.work satisfies both modules.
Copilot AI lite review requested due to automatic review settings August 21, 2026 11:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.81%. Comparing base (a3a8f79) to head (ca7a495).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   78.41%   84.81%   +6.39%     
==========================================
  Files          10       10              
  Lines         746      652      -94     
==========================================
- Hits          585      553      -32     
+ Misses        117       99      -18     
+ Partials       44        0      -44     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rustatian rustatian self-assigned this Aug 21, 2026
@rustatian
rustatian merged commit e82f594 into master Aug 21, 2026
9 checks passed
@rustatian
rustatian deleted the chore/v1-apis branch August 21, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants