build: move both escapepod pins to v0.27.1 - #351
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust/Cargo.tomlandpyproject.tomlpin the same upstream, released inlockstep from rnabioco/escapepod-rs, and leech drives both —
signal_refine.pythrough the Python binding,
refinement.rsthrough the crate. A skew betweenthem lets the two prepare backends compute different dwells and different
level-derived features from the same read, which is issue #193: invisible for
four releases, because the arrays keep their shape and look plausible either way.
Opened by
.github/workflows/escapepod-sync.ymlbecause the pins disagreed.Dependabot bumps the tag-pinned crate on its own schedule and has no way to know
a PyPI package in another manifest has to move with it.
uv.lock's escapepod entry is rewritten from PyPI's release record rather thanby
uv lock, which re-serializes the whole file (~670 changed lines, ~300packages gaining emscripten markers) and would bury the one line worth reviewing.
Verify before merging
This moves the pins and re-resolves the locks. It does not check that escapepod
still computes the same thing.
tests/test_backend_parity.pyis the check that matters. It comparesevery array in the npz across both prepare backends, which is exactly the
divergence this guards against.
cargo checkpassing says the API still exists,not that the values are unchanged.
Note: PRs opened with
GITHUB_TOKENdo not start other workflows. Push an emptycommit, or close and reopen, to run CI.