Repository navigation
fix(release): build x86_64 Linux target as static musl binary - #20
Merged
Merged
Conversation
The released lore-linux-x86_64 binary built x86_64-unknown-linux-gnu directly on the ubuntu-latest runner with no cross-compilation, so it linked against whatever glibc that runner image shipped. When ubuntu-latest rolled to 24.04 (glibc 2.39), every released binary silently required glibc 2.39+, breaking on older distros (Ubuntu 22.04, Debian 12, etc.). Building x86_64-unknown-linux-musl via cross instead produces a statically linked binary with no glibc dependency, closing this class of breakage for good. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: rjfranc0 <jean.franco.ratovoson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lore-linux-x86_64builtx86_64-unknown-linux-gnudirectly on the bareubuntu-latestrunner (no cross-compilation), so it linked against whatever glibc that runner image shipped. Whenubuntu-latestrolled to 24.04 (glibc 2.39), every released binary silently required glibc 2.39+ and broke on older distros (Ubuntu 22.04, Debian 12, etc.).x86_64-unknown-linux-musl, built viacross(same pattern already used foraarch64-unknown-linux-gnu), producing a statically linked binary with zero glibc dependency.docs/infra/release-and-distribution.mdto match (build matrix table + a new "what breaks" entry warning against reverting to a bare-gnubuild).Test plan
cross build --release --target x86_64-unknown-linux-muslsucceeds locallyfile/lddon the resulting binary confirmstatic-pie linked, not stripped/statically linkedlore versionruns correctly from the cross-compiled binarycargo test+cargo clippy -- -D warningspass (pre-push hook)workflow_dispatchrebuild of the current tag) should be checked to confirm the uploadedlore-linux-x86_64artifact is now the musl binary🤖 Generated with Claude Code