Log dropped subscription events#1271
Merged
brandur merged 4 commits intoJun 3, 2026
Merged
Conversation
brandur
reviewed
Jun 3, 2026
Contributor
brandur
left a comment
There was a problem hiding this comment.
Yeah, this isn't a bad idea. Want to add a changelog?
Contributor
Author
|
Added a changelog entry under Unreleased -> Changed. |
brandur
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subscription delivery already uses non-blocking sends and the public docs already warn that slow consumers can lose events. Right now, when a subscriber channel fills up,
subscription_managerdrops the event silently. That leaves you with no signal that a subscription fell behind or which kind of event was lost.This adds a warn log when a job or queue subscription event is dropped because the subscriber buffer is full.
The log includes
event_kindso you can tell what was lost.I kept the existing delivery semantics. This does not add retries, change buffering, or block producers behind a slow subscriber. It only turns a known lossy path into something observable.
Testing
Added
Test_SubscriptionManager/LogsDroppedQueueEventsinsubscription_manager_test.go.Ran
go test . -run Test_SubscriptionManager/LogsDroppedQueueEvents -count=1.Ran
go test . -run TestDoesNotExist -count=1as a compile/load smoke check.