fiftyone-db: Add version 1.4.1 - #2634
Merged
Merged
Conversation
Ports the first riscv64 build of fiftyone-db. Upstream's own release
workflow (build-db.yml) has no Linux leg at all: every Linux install
today builds the sdist locally, because CustomBdistWheel.get_tag()
falls through to the raw sysconfig platform string for any arch it
doesn't special-case, and that string ("linux-riscv64") is not a valid
wheel tag.
Backports the two-commit fix from voxel51/fiftyone#8637 (open, not yet
merged): normalize the platform tag the same way bdist_wheel itself
does, and give riscv64 its own manylinux_2_39_riscv64 branch. As that
PR's own description says, MongoDB ships no riscv64 binary, so the
wheel installs with an empty fiftyone/db/bin/ instead of raising -
_get_download() finds no riscv64 entry in LINUX_DOWNLOADS and returns
None, which write_wheelfile() already handles as a no-op. Callers set
database_uri to point at an external MongoDB, same as fiftyone's docs
already describe for any platform without a bundled mongod.
Mirrors upstream's own per-platform build step (`python -m build`
inside the manylinux riscv64 image, no interpreter matrix - the wheel
is tagged py3-none and carries no compiled extension), run against the
db-v1.4.1 tag rather than the whole-repo v1.4.1 tag, since fiftyone-db
versions independently of the main fiftyone package.
luhenry
added a commit
that referenced
this pull request
Oct 2, 2026
Un-parked after finding voxel51/fiftyone#8637, an open upstream PR that fixes the wheel-tagging gap that made a riscv64 build impossible at all, not just mongod-less.
Contributor
|
git -C fiftyone apply ../python-wheels/patches/.../*.patch failed with "No such file or directory" on the literal, unexpanded "*.patch" - the glob is expanded by the shell before git ever runs, using the shell's own cwd ($GITHUB_WORKSPACE, where fiftyone/ and python-wheels/ are siblings), not the directory -C switches git into. "../python-wheels" from there walks out of the workspace entirely, so the glob matched nothing and bash passed the pattern through unexpanded. Expand it from $PWD (still $GITHUB_WORKSPACE at that point) instead, so the glob actually resolves before -C's own path handling applies to each matched filename.
The build itself was fine - the wheel came out correctly tagged (fiftyone_db-1.4.1-py3-none-manylinux_2_39_riscv64.whl), with no mongod bundled and the right files. The smoke-test step then installed it with the bare runner's own python3/pip instead of the image's, and pip rejected it outright: "is not a supported wheel on this platform." The runner's pip computes platform-tag compatibility against its own glibc, not the manylinux_2_39 baseline the wheel is tagged for, so it never recognized the tag as installable even though the wheel is a perfectly good riscv64 wheel built to spec. Move the tag/contents check and the smoke-test into the same docker run as the build, so every check happens against the glibc baseline the wheel actually claims.
luhenry
marked this pull request as ready for review
October 2, 2026 15:37
luhenry
added a commit
that referenced
this pull request
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fiftyone-db1.4.1package/dbsubtree, released independently from the mainfiftyonepackage underdb-v*tags)fiftyone-dbis a thin wheel that bundles a prebuiltmongodbinary per platform; it has no compiled extension of its own. Upstream's own release workflow (build-db.yml) builds no Linux wheel at all - every Linux install today falls back to building the sdist locally, becauseCustomBdistWheel.get_tag()returns the raw sysconfig platform string for any architecture it doesn't special-case, and that string ("linux-riscv64") is not a valid wheel tag.This was previously looked at and parked as infeasible (no riscv64
mongodexists anywhere, confirmed against MongoDB's own distribution index, Gentoo, Ubuntu, and a stalled 2025 community build attempt - all still true). What changes that conclusion is voxel51/fiftyone#8637, an open upstream PR that fixes exactly the wheel-tagging gap: it normalizesget_tag()'s platform string and adds an explicitriscv64branch taggingmanylinux_2_39_riscv64. As that PR's own description states, the wheel still ships withoutmongod-_get_download()finds no riscv64 entry inLINUX_DOWNLOADSand returnsNone, whichwrite_wheelfile()already handles as a no-op, leavingfiftyone/db/bin/empty instead of raising. Callers setdatabase_urito point at an external MongoDB, exactly as fiftyone's own docs already describe for any platform lacking a bundledmongod.Differs from upstream
db-v1.4.1tag, not the whole-repov1.4.1tag -fiftyone-dbversions independently of the mainfiftyonepackage.python -m buildstep (no interpreter matrix - the wheel is taggedpy3-none, no compiled extension).Matrix: single build (
py3-none), no interpreter matrix - matches upstream's own per-platform builds.Testing: installs the built wheel into a fresh venv and imports
fiftyone.db, checking it loads cleanly with its (expectedly empty) bin directory.License: Apache-2.0, OK.
Patches
0001-package-db-normalize-the-platform-tag-in-get_tag.patch- Submitted upstream (Add riscv64 support voxel51/fiftyone#8637, not yet merged).0002-package-db-tag-riscv64-wheels-as-manylinux_2_39_riscv64.patch- Submitted upstream (same PR).