Conversation
river compiles one PyO3 extension (river._river_rust) with maturin and publishes no riscv64 wheel. Build it from the 0.26.1 tag with upstream's own [tool.cibuildwheel] config, as its pypi.yml does: one native wheel per interpreter (cp312-cp315) plus the cp311-abi3 fallback wheel built on its floor interpreter with --features abi3. The native legs also run upstream's pytest suite (code-quality.yml's no-pandas job) against the installed wheel. cp315 keeps upstream's own test-skip; numpy and scipy have no cp315 riscv64 wheel either.
luhenry
added a commit
that referenced
this pull request
Oct 2, 2026
river 0.26.1 is a portable maturin/PyO3 build (34 pure-Rust crates, no vendored native code); the draft port PR is open and its riscv64 CI is running.
Contributor
|
tests/anomaly/test_hst.py::test_missing_features is a doctest that iterates datasets.CreditCard(). On first use a river dataset downloads itself with verbose=True, so "Downloading ..." and "Uncompressing into ..." land in the doctest's output and it fails. It failed this way on cp312, cp313 and cp314, and reproduces on x86_64 with an empty ~/river_data; with the data already present it passes. Upstream's tests job avoids this by running `make download-datasets` before pytest, so run that target's command here too.
luhenry
marked this pull request as ready for review
October 2, 2026 07:11
luhenry
added a commit
that referenced
this pull request
Oct 2, 2026
All five riscv64 legs of river 0.26.1 are green (cp312/cp313/cp314 run the full pytest suite, cp315 builds, cp311-abi3 passes the import test) and the publish job dry-ran every wheel. The PR is ready for review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
river0.26.1Compiles river's PyO3 extension (
river._river_rust) with maturin. Upstream publishes no riscv64 wheel.Mirrors upstream's
pypi.yml.Differs from upstream
buildfrontend instead ofbuild[uv]- the riscv64 runner has no host uvMatrix: cp312/cp313/cp314/cp315 plus cp311-abi3, as upstream ships - no cp314t since upstream ships no free-threaded wheel; native cp311 dropped as the abi3 wheel covers it.
Testing
code-quality.yml's pytest suite on cp312-cp314 instead of upstream's import-only wheel testpandas<3riscv64 wheel for cp313/cp314tests/test_docs.pyignored - needs the repo's docs parser toolingtest_memory_usage_class[dataset2-model2]deselected - ceiling tuned to CPython 3.13, fails on 3.12 on x86_64 tooLicense: OK
cp312: 5617 passed, 81 skipped; cp313: 5617 passed, 81 skipped; cp314: 5676 passed, 75 skipped.