Conversation
setup.py's get_version() only emits the clean tag version (e.g. 0.32.2) when PYPI_RELEASE=1; otherwise it always appends .devYYYYMMDD+<git-hash>, even when building from an exact, unpatched v0.32.2 checkout. Applies to both the mlx frontend and mlx-cpu backend packages, which share the same setup.py (published so far: 0.32.2.dev20260914+1f8e74e for both).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mlx(andmlx-cpu, built by the same workflow)setup.py'sget_version()only emits the clean tag version whenPYPI_RELEASE=1; otherwise it always appends.devYYYYMMDD+<git-hash>, even when building from an exact, unpatchedv0.32.2checkout with no dirty-tree involved at all. Both mlx and mlx-cpu published so far as0.32.2.dev20260914+1f8e74einstead of the clean0.32.2.Fix: export
PYPI_RELEASE=1in both thebuild_backend(mlx-cpu) andbuild_frontend(mlx) jobs.License: OK, unchanged.