Repository navigation
Conversation
ase (a CIBW_TEST_REQUIRES-only dependency) pulls in numpy/scipy/matplotlib. PIP_ONLY_BINARY only covered cmake, so pip could resolve a newer PyPI-only release of one of ase's own deps and fall back to building it from source (gotcha 291's pattern: a test dependency's own runtime deps are what break, not the test dependency itself).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vesinThe CI test step installs
ase(test-only, per upstream's own workflow), which pulls innumpy,scipy, andmatplotlibas its own runtime dependencies.PIP_ONLY_BINARYonly namedcmake, so pip could resolve a newer PyPI-only release of one of those and fall back to building it from source on riscv64 instead of using our registry's riscv64 wheels.Fix: extend
PIP_ONLY_BINARYtocmake,numpy,scipy,matplotlib, scoped to those names only (not:all:) so nothing else in the resolve is forced off sdist.License: OK, unchanged.