fix(users): mask PII in search endpoint response#1062
Open
boalambo wants to merge 1 commit into
Open
Conversation
- Add UserPublicDto exposing only id, displayName, avatarUrl, role - Add UserAdminDto (extends UserPublicDto) for admin-scoped results with email, status, isEmailVerified - Add UsersController with GET /users search endpoint, role-gated DTO selection - Add UsersService.searchUsers with query builder, fix role relation join and search predicate - Register UsersModule in AppModule - Add unit tests verifying email/refreshToken/passwordHistory absence for non-admin results and presence of admin fields for admin results Closes rinafcode#879
|
@boalambo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #879