feat(payments): add daily reconciliation job for unmatched transactio…#1061
Open
lamborghini21 wants to merge 1 commit into
Open
feat(payments): add daily reconciliation job for unmatched transactio…#1061lamborghini21 wants to merge 1 commit into
lamborghini21 wants to merge 1 commit into
Conversation
|
@lamborghini21 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #856 Adds a daily payment reconciliation job that compares locally recorded payments against the payment provider's transaction ledger, flags unmatched or mismatched transactions, and logs them as structured audit events. Also exposes an admin-only endpoint to retrieve the results of the last reconciliation run.
Changes
src/payments/reconciliation/reconciliation.service.ts(new)PaymentReconciliationJobruns daily at 02:00 UTC via@Cron.Paymenttable records by provider transaction ID.src/payments/reconciliation/reconciliation.controller.ts(new)GET /payments/reconciliation/report— admin-only, returns the results of the last reconciliation run.src/audit-log/enums/audit-action.enum.tsPAYMENT_RECONCILIATION_MISMATCHas a new audit action (additive only, no existing values changed).src/payments/payments.module.tssrc/app.module.ts@Cronsupport.Acceptance Criteria
Testing
Added
src/payments/reconciliation/reconciliation.service.spec.tscovering:All 4 scoped tests passing locally via Jest.
Notes
reconciliation.service.ts,audit-action.enum.ts), plus the controller and module wiring needed to actually expose the endpoint and register the job.package-lock.jsonor unrelated dependencies.