feat: implement environment validation schema and test setup infrastureucture.#1059
Open
dot-enny wants to merge 1 commit into
Open
feat: implement environment validation schema and test setup infrastureucture.#1059dot-enny wants to merge 1 commit into
dot-enny wants to merge 1 commit into
Conversation
|
@dot-enny Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #831
Summary of Changes
New Branch Created:
feature/831-configurable-bcrypt-rounds.Configurable Cost Factor (
src/auth/auth.service.ts):ConfigServiceintoAuthService.bcrypt.genSalt(10)withbcrypt.genSalt(Number(this.configService.get('BCRYPT_ROUNDS', 12))).Startup Environment Validation (
src/config/env.validation.ts&scripts/validate-env.js):BCRYPT_ROUNDSschema rule to ensure cost factor is between 10 and 14 (min(10).max(14)), defaulting to 12.Environment Template Updated (
.env.example):BCRYPT_ROUNDSdocumentation to reflect the OWASP recommended cost factor (12) and default value.Unit Tests and Performance (
src/auth/auth.service.spec.ts,src/config/env.validation.spec.ts,test/setup.ts,test/setup.js):BCRYPT_ROUNDS=10in test setup and mock configuration for fast execution during testing.All tests have passed successfully. The solution is complete and verified.