Repository navigation
Conversation
…iptService and MailStorageScriptService DeprecatedMailStorageScriptService now extends MailStorageScriptService instead of duplicating all shared methods (load, count, delete, deleteAll, normalizeFilterMap, loadMessage, getConfiguration, resend, resendAsynchronously). Only the differing ERROR_KEY and legacy resendAsynchronously(filterMap) method are retained in the deprecated class. Changed normalizeFilterMap() and loadMessage() visibility from private to protected in MailStorageScriptService to support inheritance. Detected by PMD CPD with --minimum-tokens 100.
…e-clone Refactor: Remove 161-line code clone between DeprecatedMailStorageScr…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira URL
shibinkoshygit#7
Changes
Refactored codes from DefaultGroupingEventStrategyTest.java, DefaultParametrizedNotificationManagerTest.java and created a new file named NotificationTestEventFactory.java
Description
CPD detected duplicated helper code for creating mocked Event objects in DefaultGroupingEventStrategyTest and DefaultParametrizedNotificationManagerTest. I will extract the duplicated helper into a shared test utility class named NotificationTestEventFactory and update both tests to use it.