Windows: update to hiredis 1.0.0 - #35
Closed
jeroen wants to merge 2 commits into
Closed
Conversation
richfitz
reviewed
Oct 22, 2020
richfitz
left a comment
Owner
There was a problem hiding this comment.
Thanks Jeroen; looks like you're hitting some CI rot here, and I'll need to do some work to patch up the travis builds, which I'll probably port over to GHA at the same time. I don't have time to do this in the next week or two probably, but will try and look at this shortly...
Comment on lines
+16
to
+17
| # - redis-server --service-install | ||
| # - redis-server --service-start |
Owner
There was a problem hiding this comment.
Suggested change
| # - redis-server --service-install | |
| # - redis-server --service-start |
Looks like these are not needed
Contributor
Author
There was a problem hiding this comment.
OK I'll remove those
Contributor
Author
|
OK, the changes in this PR are Windows only, so unrelated to Travis (the appveyor build passes). So I think you can go ahead and merge this to unblock Jeremy. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for a user that is working on SSL support.
Also, the chocolately
redis-64package seems to be deprecated, and is now a virtual package that installs another one. From the description: