feat(rollupdice): include the rollup dice software - #48
Merged
Merged
Conversation
Rollup dice was a separate repository built against the SDK as it was then: dep for its dependencies, urfave/cli.v1, and the protobuf messages passed by value. It no longer built against matrix, and the README pointed at it rather than shipping it. The logic is unchanged, and so are the logo and the pip font, so the dice look the same on the panel: two faces, pips drawn through the caracter driver, and a reroll on the A button. Three things differ from the original: - the faces are placed from a faceSize constant rather than from hardcoded coordinates, so both of them and their pips share the same arithmetic - the engine draws from the global math/rand source rather than one seeded from time.Now(). The board has no RTC, so a clock-seeded generator would deal the same sequence at every boot; the runtime seeds the global source whatever the clock says - it rerolls on the A release only, where before it re-rendered on every button event, including the ones it ignores Being in-tree, it travels with the releases: it is in the default component list of the .deb, of the Alpine card script and of the tarball, so it is on the console without a second binary to install. ArgsUsage is the list printed when a component name is rejected, and it was missing getout, animate and light. All four names are added, not just the new one, so the error stops calling a valid component invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup dice was a separate repository built against the SDK as it was then: dep for its dependencies, urfave/cli.v1, and the protobuf messages passed by value. It no longer built against matrix, and the README pointed at it rather than shipping it.
The logic is unchanged, and so are the logo and the pip font, so the dice look the same on the panel: two faces, pips drawn through the caracter driver, and a reroll on the A button. Three things differ from the original:
Being in-tree, it travels with the releases: it is in the default component list of the .deb, of the Alpine card script and of the tarball, so it is on the console without a second binary to install.
ArgsUsage is the list printed when a component name is rejected, and it was missing getout, animate and light. All four names are added, not just the new one, so the error stops calling a valid component invalid.