Repository navigation
feat(docs): let docs iframe use fullscreen and autoplay - #89
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Videos in UP Docs documents could not go fullscreen or autoplay after a click, because the docs panel iframe only delegated clipboard permissions.
This adds
fullscreenandautoplayto the iframe'sallowvalue. Thesandboxvalue and the embed protocol are unchanged.Desktop: the main window uses the default Electron session, which has no permission handler, so nothing denies fullscreen. Its
disableHtmlFullscreenWindowResizesetting means fullscreen fills the T3 Code window rather than the whole screen. That setting is unchanged here.Verification:
apps/webtypecheck and 87 focused tests pass. Not tried in a running client.check:changedfails on lint and knip for existing issues outside this one-line change.Claude Opus 5.5, Claude Code
🤖 Generated with Claude Code