[release-2.5] Cherry-pick a5f61ce71d1e38708c2f7bd3fc034fb5a72fd6a5 from upstream - #1938
Conversation
tryRemovingLabel() decided whether to strip the kmm.node.k8s.io/contains-modules namespace label by counting *all* Modules still present in the namespace, including sibling Modules that were themselves mid-deletion (DeletionTimestamp set, finalizer not yet removed). When several Modules in the same namespace were deleted around the same time, each one's reconcile could see its still-terminating siblings in that count and skip removing the label - while still unconditionally finalizing itself right after. Once all Modules finished terminating this way, nothing was left to ever retrigger the cleanup, leaving the label - and the namespace-deletion webhook denial - stuck permanently even though no Modules remained. Only count Modules without a DeletionTimestamp (i.e. not themselves being deleted) when deciding whether to keep the label, since a terminating sibling can't be relied on to perform the cleanup later. Upstream-Commit: a5f61ce71d1e38708c2f7bd3fc034fb5a72fd6a5
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, TomerNewman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/override ci/prow/security |
|
@TomerNewman: Overrode contexts on behalf of TomerNewman: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
1 similar comment
|
/retest |
|
/hold |
|
/unhold |
|
/override ci/prow/security |
|
@TomerNewman: Overrode contexts on behalf of TomerNewman: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a7132a6
into
rh-ecosystem-edge:release-2.5
2 participants
This is an automated cherry-pick of #1935
/assign TomerNewman