feat: activate the panel window when the hotkey opens it on Windows - #54
Merged
Conversation
Windows only grants foreground rights while the process owns the input that caused the change. WM_HOTKEY grants it, but the notification crosses to Dart and waits on several platform calls before asking for focus, so by then the right is gone: SetForegroundWindow reports success while merely flashing the taskbar button, leaving the panel visible but inactive and spending the user's first click on activating it. Attaching our input queue to the foreground thread restores the right for the duration of the call — the same technique the paste path already uses to restore the destination window. Closes #49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows only grants foreground rights while the process owns the input that caused the change. WM_HOTKEY grants it, but the notification crosses to Dart and waits on several platform calls before asking for focus, so by then the right is gone: SetForegroundWindow reports success while merely flashing the taskbar button, leaving the panel visible but inactive and spending the user's first click on activating it.
Attaching our input queue to the foreground thread restores the right for the duration of the call — the same technique the paste path already uses to restore the destination window.
Closes #49