Skip to content

Reject maps with asymmetric tiles #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sadhana19zzz-beep wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reject maps with asymmetric tiles #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions engine/content.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,21 @@ func (c *Content) Validate() error {
if len(m.Tiles) != m.Width*m.Height {
return fmt.Errorf("map %s: %d tiles for %dx%d", m.ID, len(m.Tiles), m.Width, m.Height)
}

for y := 0; y < m.Height; y++ {
for x := 0; x < m.Width; x++ {
i := y*m.Width + x
rx, ry := m.Width-1-x, m.Height-1-y
ri := ry*m.Width + rx

if m.Tiles[i] != m.Tiles[ri] {
return fmt.Errorf(
"map %s: tile (%d,%d) differs from its 180-degree counterpart (%d,%d)",
m.ID, x, y, rx, ry,
)
}
}
}
for _, o := range m.Objectives {
for _, p := range o.Tiles {
if p.X < 0 || p.Y < 0 || p.X >= m.Width || p.Y >= m.Height {
Expand Down
12 changes: 12 additions & 0 deletions engine/symmetry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,15 @@ func TestSummonKillGivesNoCredit(t *testing.T) {
t.Fatalf("summon kill credited: team kills %d, hask xp %d", k, a.u(h.ID).XP)
}
}

func TestValidateRejectsAsymmetricMap(t *testing.T) {
c := content(t)

m := c.Maps["relay"]
m.Tiles[0].Terrain = m.Tiles[len(m.Tiles)-1].Terrain + "-changed"
c.Maps["relay"] = m

if err := c.Validate(); err == nil {
t.Fatal("expected validation to reject an asymmetric map")
}
}
Loading